Completed
Last Updated:
27 Mar 2023 06:39
by ADMIN
Release R1 2023 SP1
Martin
Created on:
13 Jan 2023 12:37
Category:
UI for WinForms
Type:
Bug Report
Cut method of RadVirtualGrid deletes rows prematurely.
The Cut operations of the RadVirtualGrid does not work.
When the SelectionMode is set to FullRowSelect, MultiSelect = true, and multiple rows are selected, the loop goes something like this:
// Pseudo code:
for(int rowIndex = firstRow; rowIndex <= lastRow; rowIndex++)
{
AddRowToClipboardData(rowIndex)
UserDeletedRow(rowIndex);
}- Lets say 10 rows are selected, only the even rows get copied. First row 0 is copied and deleted. When row 0 is deleted, all rows move a position down. So when copying row 1, it is actually row 2 that is copyied.
- When cutting all rows, in my case an exception is thrown, because a rowIndex larger than the number of rows is referred to.
- When cutting to multiple clipboard formats, the second format will not contain the original selected data, because it has already been deleted.
My suggestion:
- First copy all the data and formats to the clipboard.
- Then delete the selected rows.
5 comments
ADMIN
Dinko | Tech Support Engineer
Posted on:
23 Jan 2023 12:09
Martin
Posted on:
20 Jan 2023 10:08
ADMIN
Dinko | Tech Support Engineer
Posted on:
19 Jan 2023 12:33
Martin
Posted on:
17 Jan 2023 13:13
Here is my example code.
With this you can create multiple bugs:
Bug 1:
- Select all
- Cut
- Observed: The grid will crash
Expected: No crash
Bug 2:
- Download Free Clipboard Viewer
- Select values 0 till 5.
- Cut
- In Clipboard Viewer you will see:
- Text: 0 2 4 6 8 10 (Expected: 0, 1, 2, 3, 4, 5)
- CSV: 1 5 9 12 14 16 (Expected: 0, 1, 2, 3, 4, 5)
- Also:
Observed: The grid is not synchronized.
Expected: That grid is synchronized.
The code:
using System.Data;
using System.Linq;
using System.Windows.Forms;
using Telerik.WinControls.UI;
namespace Turien.Schade.PremiumCalculator.TestForms
{
public partial class TestForm : Form
{
private readonly DataView _view;
public TestForm()
{
InitializeComponent();
_view = new DataView(LoadTable());
_grid.ColumnCount = _view.Table.Columns.Count;
_grid.RowCount = _view.Count;
}
static private DataTable LoadTable()
{
var table = new DataTable();
table.Columns.Add("Number", typeof(int));
for (int i = 0; i < 20; i++)
table.Rows.Add(i);
return table;
}
#region Windows Form Designer generated code
/// <summary>
/// Required method for Designer support - do not modify
/// the contents of this method with the code editor.
/// </summary>
private void InitializeComponent()
{
this._grid = new Telerik.WinControls.UI.RadVirtualGrid();
((System.ComponentModel.ISupportInitialize)(this._grid)).BeginInit();
this.SuspendLayout();
//
// _grid
//
this._grid.Dock = System.Windows.Forms.DockStyle.Fill;
this._grid.Location = new System.Drawing.Point(0, 0);
this._grid.MultiSelect = true;
this._grid.Name = "_grid";
this._grid.SelectionMode = Telerik.WinControls.UI.VirtualGridSelectionMode.FullRowSelect;
this._grid.Size = new System.Drawing.Size(800, 450);
this._grid.TabIndex = 0;
this._grid.CellValueNeeded += new Telerik.WinControls.UI.VirtualGridCellValueNeededEventHandler(this._grid_CellValueNeeded);
this._grid.UserDeletedRow += new Telerik.WinControls.UI.VirtualGridRowsEventHandler(this._grid_UserDeletedRow);
//
// TestForm
//
this.AutoScaleDimensions = new System.Drawing.SizeF(6F, 13F);
this.AutoScaleMode = System.Windows.Forms.AutoScaleMode.Font;
this.ClientSize = new System.Drawing.Size(800, 450);
this.Controls.Add(this._grid);
this.Name = "TestForm";
this.Text = "TestForm";
((System.ComponentModel.ISupportInitialize)(this._grid)).EndInit();
this.ResumeLayout(false);
}
#endregion
private Telerik.WinControls.UI.RadVirtualGrid _grid;
private void _grid_CellValueNeeded(object sender, Telerik.WinControls.UI.VirtualGridCellValueNeededEventArgs e)
{
if (e.ColumnIndex < 0)
return;
if (e.RowIndex < 0)
{
e.FieldName = _view.Table.Columns[e.ColumnIndex].ColumnName;
if (e.RowIndex == RadVirtualGrid.HeaderRowIndex)
e.Value = e.FieldName;
}
else
{
e.Value = _view[e.RowIndex][e.ColumnIndex];
}
}
private void _grid_UserDeletedRow(object sender, Telerik.WinControls.UI.VirtualGridRowsEventArgs e)
{
var rowIndexes = e.RowIndices.Distinct().OrderByDescending(i => i).ToList(); // Off topic: I have seen duplicate row indexes in this row collection. And unsorted. Is that by design?
if (rowIndexes.Count == _view.Count)
{
_view.Table.Rows.Clear();
}
else
{
foreach (var index in rowIndexes)
_view[index].Delete();
}
}
}
}
ADMIN
Dinko | Tech Support Engineer
Posted on:
17 Jan 2023 09:16