Completed
Last Updated: 08 Mar 2019 09:45 by ADMIN
Eric
Created on: 18 Jan 2019 08:03
Category: Editor
Type: Bug Report
0
z.push is not a function JS error - RadEditor WordListConverter convert method bug

There's a bug in the RadEditor WordListConverter convert method.  See the attached image for details.  Note that the variable z is initialized and treated as an array (a stack, actually, with its items being pushed in and popped out).  However, perhaps because of a naming scope failure in the js-minifier, the z variable is, under certain conditions, set equal to an HTMLCollection, so a subsequent z.push method call fails.

This sample Word document reproduces the error.  It is admittedly full of bad list formatting, because it began life as a PDF, but it does exercise the RadEditor code in a way that causes the problem.  Select and copy its content and paste it in the RadEditor demo page here:

https://demos.telerik.com/aspnet-ajax/editor/examples/overview/defaultcs.aspx

Click OK to "clean" the pasted content and note that nothing appears because of the error shown in the attached image.

Verified in the latest Chrome and FF builds on Windows 10.

9 comments
ADMIN
Rumen
Posted on: 08 Mar 2019 09:45
I have good news that the problem is fixed and available for testing in the Latest Internal Build version 2019.1.308.

You can download the LIB from https://www.telerik.com/account/product-download?product=RCAJAX -> click on the Internal Builds tab -> download Telerik_UI_for_ASP.NET_AJAX_2019_1_308_Dev_hotfix.zip or Telerik_UI_for_ASP.NET_AJAX_2019_1_308_Trial_hotfix.zip depending on your license.

Here are the Release Notes.

As Marin already wrote, the fix will be also part of the upcoming in May major R2 2019 release.

Best regards,
Rumen
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
ADMIN
Marin Bratanov
Posted on: 28 Feb 2019 09:41
Hi guys,

@Eric - I am attaching below a minified version of the override.

@Ron - the fix has been committed to the source control, but that was done after the R1 2019 SP1 release (the current latest that our demos also run on). The fix will be part of our next official release - R2 2019. At the moment the feedback portal does not show the planned releases, and we are working on improving that. I'm sorry for this. For the time being you can use the provided workaround.


Regards,
Marin Bratanov
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
Ronald
Posted on: 28 Feb 2019 03:14

This is not corrected as it continues to also be an issue in Teleriks demo site and the latest trial version as I have been experiencing the same issue.

 

-Ron

Eric
Posted on: 27 Feb 2019 16:55

Marin, that's great, thanks - I really appreciate having the pre-minified version of that logic.

 

ewb

ADMIN
Marin Bratanov
Posted on: 27 Feb 2019 13:15
I am attaching here a second reproducible and a potential workaround that can help get rid of the error (although it may not help with fixing the malformed content as that comes from Word).

--Marin

ADMIN
Rumen
Posted on: 06 Feb 2019 10:22
I am also attaching a simplified version of the content which reproduces the issue.

Regards,
Rumen
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
Attached Files:
ADMIN
Rumen
Posted on: 06 Feb 2019 10:20
You are welcome, Eric!

What you can do in Sitefinity is to locate the RadEditor related field and its StripFormattingOptions property and remove from the default values "MSWordRemoveAll, Css, Font, Span, ConvertWordLists" the ConvertWordLists option, which is causing the problem.

Regards,
Rumen
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
Eric
Posted on: 25 Jan 2019 17:31

Rumen, thanks.  Glad you were able to fix it.

I discovered it in a Sitefinity system, where this component is used for HTML content editing in the admin interface.  Unfortunately, the RadEditor code is embedded in a Sitefinity resource DLL so it'll be some time (and a few versions) before we're able to benefit from it.

Thanks for the points!

ADMIN
Rumen
Posted on: 25 Jan 2019 11:11
Hi Eric,

Thank you for reporting this bug and the detailed information you provided! Much appreciated.

The problem was recognized and that's why I directly converted the forum post to a bug report portal item.

I have good news that we fixed it and it won't exist in the next version of the control.

As a small note of gratitude for your bug report, I updated your Telerik points.


Best regards,
Rumen
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.