Unplanned
Last Updated: 24 Oct 2024 09:36 by ADMIN
AGB
Created on: 07 Aug 2024 15:45
Type: Bug Report
0
Unable to set SASS variables $kendo-disabled-opacity & $kendo-disabled-filter (Kendu UI v2024.3.806 & kendo-theme-classic v8.2.1)

Hi Guys,

Have just upgraded to the Kendo UI v2024.3.806 along with kendo-theme-classic v8.2.1 and have noticed you can no longer set the $kendo-disabled-opacity & $kendo-disabled-filter variables to override their values because they are now being hard set in the following section within the 'all.scss' file.

// Backward compatibility
// #region @import "./color-system/_swatch-legacy.scss"; -> scss/core/color-system/_swatch-legacy.scss
@if ($kendo-enable-color-system) {
    ...
    $kendo-disabled-opacity: .6;
    $kendo-disabled-filter: grayscale(.1);
    ...
}

This is a regression from

    @progress/kendo-theme-classic:8.0.1

where neither of these variables were being hard set.

Also can you confirm what version of the SASS themes are compatible with the latest Kendo UI because the latest version on NPM is now v9.0.0 which was released 3 days prior to Kendo UI v2024.3.806.

NOTE: kendo-theme-classic: 9.0.0 also has these two variables hard set.

Regards
Alan

4 comments
ADMIN
Emil
Posted on: 24 Oct 2024 09:36

Hi Alan,

Thank you for reaching back!

I understand your frustration and would like to apologise if we have set a wrong impression.

You have asked what is causing the delay on shipping a fix, so I will try to explain the reason behind it.

As you are probably aware the legacy node-sass compiler has reached end-of-life state and will no longer receive fixes even if they are related to security.

This also means that the @import syntax which we are currently using in our implementation will be completely removed.

With the above in mind we are currently working on upgrading to the latest dart-sass implementation and dropping support for node-sass, which requires significant infrastructure efforts and that is where our current focus lies.

This does not mean however that we will not be addressing important bug fixes like the one referred here.

I hope this provides some insight into what caused the delay and again aplogise for the inconvenience this has produced.

 

 

Regards,
Emil
Progress Telerik

Love the Telerik and Kendo UI products and believe more people should try them? Invite a fellow developer to become a Progress customer and each of you can get a $50 Amazon gift voucher.

AGB
Posted on: 17 Oct 2024 10:39
Hi Guys,

Just updated to Kendo UI v2024.3.1015 & kendo-theme-classic v9.0.0 and this issue still hasn't been resolved.

All it takes is a quick edit of the 'Backward compatibility' section and add

    !default;

to the end of all the hard set variables ... Job Done.

So what's the delay or is this going to be another bug which languishes in your priorly queue never to be addressed.

Regards
Alan
ADMIN
Emil
Posted on: 14 Aug 2024 14:07

Hello Alan,

First let me apologise for any inconveniece the reported behaviour has caused.

Please be informed that we have been made aware of this regression and have an official issue in our repository to which you can subscribe if you wish.

We will be prioritizing this regression and a fix should be available in one of the upcomming releases of the Kendo themes.

For the time being we can offer the following workaround through the disabled mixin:

@import'@progress/kendo-theme-classic/dist/all.scss';

// Overriding the dedicated disabled class

.k-disabled { @include disabled($opacity: .8); }

// Or if you need to be more specific

.k-button.k-disabled {

@include disabled( $bg: red, $color: white );

}

On the matter related to the compatibility with Kendo UI, the latest version of the package is compatible with v8.2.1 of the Kendo themes.

For more information or future reference you can visit this page.

 

Regards,
Emil
Progress Telerik

Love the Telerik and Kendo UI products and believe more people should try them? Invite a fellow developer to become a Progress customer and each of you can get a $50 Amazon gift voucher.

AGB
Posted on: 09 Aug 2024 07:26
Thinking about this further, the whole 'Backward compatibility' region is wrong because it overrides and hard sets every variable within it, irrespective of a developers previous choices.

Surely every variable within it should have a '!default' flag appended.