When a Dialog is shown from a modal Window, the Dialog appears behind the Window on second opening.
Here is a test page with a workaround:
@inject IJSRuntime js
<TelerikButton OnClick="@( () => WindowVisible = true )">Show Window</TelerikButton>
<TelerikWindow @bind-Visible="@WindowVisible"
Modal="true">
<WindowActions>
<WindowAction Name="Minimize" />
<WindowAction Name="Close" />
</WindowActions>
<WindowTitle>
Window Title
</WindowTitle>
<WindowContent>
<p>Window Content</p>
<TelerikButton OnClick="@OnShowDialogButtonClick">Show Dialog</TelerikButton>
</WindowContent>
</TelerikWindow>
<TelerikDialog @bind-Visible="@DialogVisible"
Width="300px"
Class="dialog-on-window">
<DialogTitle>
Dialog Title
</DialogTitle>
<DialogContent>
<p>Dialog Content</p>
</DialogContent>
<DialogButtons>
<TelerikButton OnClick="@( () => OnDialogButtonClick(true) )">OK</TelerikButton>
</DialogButtons>
</TelerikDialog>
<script suppress-error="BL9992">
function bringDialogToTop() {
var dialogWrapper = document.querySelector(".dialog-on-window").closest(".k-dialog-wrapper");
if (dialogWrapper) {
dialogWrapper.style.zIndex = parseInt(dialogWrapper.style.zIndex) + 2;
}
}
</script>
@code {
private bool WindowVisible { get; set; }
private bool DialogVisible { get; set; }
private bool ShouldFocusDialog { get; set; }
private void OnShowDialogButtonClick()
{
DialogVisible = true;
ShouldFocusDialog = true;
}
private void OnDialogButtonClick(bool result)
{
DialogVisible = false;
}
protected override async Task OnAfterRenderAsync(bool firstRender)
{
if (ShouldFocusDialog)
{
ShouldFocusDialog = false;
await Task.Delay(1);
await js.InvokeVoidAsync("bringDialogToTop");
}
await base.OnAfterRenderAsync(firstRender);
}
}
The issue can be reproduced when clicking on a button that opens a predefined Dialog, then making some changes on the page and hot reloading. In this scenario, I get the following error:
Microsoft.JSInterop.JSException: Cannot read properties of null (reading 'addEventListener') TypeError: Cannot read properties of null (reading 'addEventListener')
There is a bug where DialogFactory is not resetting custom button text. In this example, if you click Show Prompt, the buttons are OK/CANCEL, then click Show Prompt with Title, Default Input Text and Custom Buttons, the buttons show READY/REJECT, clicking Show Prompt a second time will show the button text as READY/REJECT.
Hello,
I am using DialogFactory in a Blazor server app with PreRendering disabled.
It appears to cause more than expected OnParametersSet calls - its firing 2-6 times per page opening. Without DialogFactory it fires only once.
Hello I want to close a TelerikDialog using Esc key and this does not work sometimes. Run this REPL snippet please https://blazorrepl.telerik.com/cnYrwUYq54FZ70xP17. Click into dialog title for instance and press Esc key. Nothing happens.
Very thanks.
Miroslav
Hi!
Please check the example:
https://blazorrepl.telerik.com/mdaIltlV32cFnMiX42
Why is predefined dialog put in to the back? This happens when i show predefined dialog from OnInitialize or AfterRendered method.
Regards, BoĊĦtjan
Pressing Espace in a focused SearchBox throws an "Error: System.ObjectDisposedException: The CancellationTokenSource has been disposed." exception.
<AdminEdit>
A workaround that will solve the issue until the fix is released.
<TelerikDialog @bind-Visible="@Visible"
Title="@Title">
<DialogContent>
<TelerikGrid Data=@GridData Pageable="true" Height="400px" Width="700px">
<GridToolBar>
<span class="k-toolbar-spacer"></span> @* add this spacer to keep the searchbox on the right *@
<div onkeydown="event.stopPropagation()">
<GridSearchBox />
</div>
</GridToolBar>
<GridColumns>
<GridColumn Field="@(nameof(Employee.EmployeeId))" />
<GridColumn Field=@nameof(Employee.Name) />
<GridColumn Field=@nameof(Employee.Team) Title="Team" />
<GridColumn Field=@nameof(Employee.IsOnLeave) Title="On Vacation" />
</GridColumns>
</TelerikGrid>
</DialogContent>
</TelerikDialog>
@code {
private bool Visible { get; set; } = true;
private string Title { get; set; } = "Software Update";
public List<Employee> GridData { get; set; }
protected override void OnInitialized()
{
GridData = new List<Employee>();
var rand = new Random();
for (int i = 0; i < 15; i++)
{
GridData.Add(new Employee()
{
EmployeeId = i,
Name = "Employee " + i.ToString(),
Team = "Team " + i % 3,
IsOnLeave = i % 2 == 0
});
}
}
public class Employee
{
public int EmployeeId { get; set; }
public string Name { get; set; }
public string Team { get; set; }
public bool IsOnLeave { get; set; }
}
}
</AdminEdit>
ADMIN EDIT
You can use the code snippet below to test this behavior in your app. At the end of the post you will find two sample apps attached that use that same code - one is OK, the other exhibits the issue. The difference in them is the layout. The one that works OK has the old MS template from over a year ago where there is an <app> element above the root of the blazor components, and that element has display: flex. The problematic app has the newer template without such a parent element - the parent element is not the <body> and it does not have display:flex. You can add in the following rule to it to see it will fix the dialog overlay error (but it can damage the layout of the app).
sample rule to fix the issue in the problematic app
body {
display:flex;
}
sample code to test the behavior
<TelerikWindow Modal="true" @bind-Visible="@isModalVisible">
<WindowTitle>
<strong>The Title</strong>
</WindowTitle>
<WindowContent>
I am modal so the page behind me is not available to the user.
<br />
<TelerikButton OnClick="@( _ => isSecondModalVisible = true )">Open the SECOND window</TelerikButton>
<TelerikButton OnClick="@ShowConfirmWithTitle">Show Confirm</TelerikButton>
</WindowContent>
<WindowActions>
<WindowAction Name="Minimize" />
<WindowAction Name="Maximize" />
<WindowAction Name="Close" />
</WindowActions>
</TelerikWindow>
<TelerikWindow Modal="true" @bind-Visible="@isSecondModalVisible">
<WindowTitle>
<strong>The SECOND</strong>
</WindowTitle>
<WindowContent>
Second modal!
</WindowContent>
<WindowActions>
<WindowAction Name="Minimize" />
<WindowAction Name="Maximize" />
<WindowAction Name="Close" />
</WindowActions>
</TelerikWindow>
<TelerikButton OnClick="@( _ => isModalVisible = true )">Open the window</TelerikButton>
@code{
[CascadingParameter]
public DialogFactory Dialogs { get; set; }
bool isModalVisible { get; set; }
bool isSecondModalVisible { get; set; }
async Task ShowConfirmWithTitle()
{
bool isConfirmed = await Dialogs.ConfirmAsync("Are you sure?", "Confirmation!");
Console.WriteLine($"The user is sure: {isConfirmed}.");
}
}
https://blazorrepl.telerik.com/cGEHOxYU12TavfAP41
Dialog component does not recalculate its z-index based on the existing window components. Thus, it is displayed behind the window.
I have a Modal Window showing and then show a Predefined Dialog alert. You can click on the modal window and the Alert dialog goes behind and you have to close the modal, then close the alert dialog.
It would be nice if the the predefined dialogs were always modal on top of all windows.