Under Review
Last Updated: 29 Jan 2019 23:45 by Kevin
Eric
Created on: 22 Jan 2019 17:46
Type: Bug Report
0
Response inspector sort order broken when PDFView inspector is installed

When the PDFView Inspector is installed (v1.1.0.3, whose public override int GetOrder() method returns 500), the Response Inspectors are rendered out of order, such that the Headers/Transformer inspectors are not at the front of the list.

 

 

Attached Files:
7 comments
Kevin
Posted on: 29 Jan 2019 23:45

just use Comparer<int>.Default.Compare(x, y)

Eric
Posted on: 29 Jan 2019 18:19
Hey, Lance-- Fiddler's code here is still buggy. The Comparer should be re-written to use Int64 math and the result should then be thunked down (to -1,0, or 1) based on the sign of the result.
ADMIN
Lance | Technical Support Engineer, Principal
Posted on: 29 Jan 2019 17:15
@Kevin,
Thank you for updating the thread.

@Eric,
I'll mark this as Completed, but if it pops up again, just let me know and I'll reopen it.

Regards,
Lance | Technical Support Engineer, Principal
Progress Telerik
Do you want to have your say when we set our development plans? Do you want to know when a feature you care about is added or when a bug fixed? Explore the Telerik Feedback Portal and vote to affect the priority of the items
Kevin
Posted on: 29 Jan 2019 16:52
Mkay I fixed it. I'm deeply sorry for using a big number. I will only use small numbers going forward.
Lance
Posted on: 23 Jan 2019 18:52
Posting to keep thread informed: https://github.com/vcsjones/FiddlerCert/issues/22
EricLaw
Posted on: 23 Jan 2019 17:46

So, the real problem here is related to the Fiddler CertInspector (https://github.com/vcsjones/FiddlerCert/issues/22) which returns `Int.MaxValue` as its order. This breaks due to integer underflow in InspectorComparer's Compare method, which uses Integer subtraction which underflows.

I've asked Kevin to fix this in his Inspector but perhaps the Comparer should be tweaked to use an Int64 subtraction? 

 
Eric
Posted on: 22 Jan 2019 22:37
Weirdly, this doesn't reproduce on every machine, so I'm not entirely sure what is going on here.